Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Enum in Matrimonial Property Scheme - Rel 4.0 final solution #135

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

celinevananraad
Copy link
Collaborator

For each applicant, in the field "matrimonialPropertyScheme" in the object "applicantDetail", we can send information how the property is owned: jointEstate
separateEstate
contributionToJointAcquiredProperty

In Case, the mortgage is for two debtor, but the property is owned by only Debtor A of these two debtor: What do you send in this field for Debtor A? --> I would say "separateEstate" What do you send in this field for Debtor B? --> There is no enum for this. Do you send it empty?

I would suggest to add a new enum: "none" or "n-a". So that we can send a clear message to the FI.

For each applicant, in the field "matrimonialPropertyScheme" in the object "applicantDetail", we can send information how the property is owned:
jointEstate
separateEstate
contributionToJointAcquiredProperty

In Case, the mortgage is for two debtor, but the property is owned by only Debtor A of these two debtor:
What do you send in this field for Debtor A? --> I would say "separateEstate"
What do you send in this field for Debtor B? --> There is no enum for this. Do you send it empty?

I would suggest to add a new enum: "none" or "n-a". So that we can send a clear message to the FI.
@celinevananraad celinevananraad linked an issue Dec 21, 2022 that may be closed by this pull request
@celinevananraad celinevananraad self-assigned this Dec 21, 2022
@rolfwagner rolfwagner added this to the Mortgage API Release 4.0.0 milestone Jan 30, 2023
rolfwagner
rolfwagner previously approved these changes Jan 30, 2023
Copy link
Contributor

@rolfwagner rolfwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, reviewed in SFTI Mortgage meeting 30.01.23

dkoeni
dkoeni previously approved these changes Oct 20, 2023
Copy link
Contributor

@dkoeni dkoeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@stephan-gerber stephan-gerber requested a review from a team as a code owner October 31, 2024 12:54
Copy link

@stephan-gerber stephan-gerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@stephan-gerber stephan-gerber merged commit 4af832f into main Oct 31, 2024
6 checks passed
@stephan-gerber stephan-gerber deleted the 119-new-enum-in-matrimonial-property-scheme-1 branch October 31, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done (released)
Development

Successfully merging this pull request may close these issues.

New Enum in Matrimonial Property Scheme
4 participants